Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1293?usp=email )
Change subject: push: Fix conversion issues related to timeout in send_auth_pending_messages ...................................................................... Patch Set 5: Code-Review-1 (2 comments) Patchset: PS5: Not sure I understand all the implications. It would be good if @[email protected] had a look. File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/1293/comment/0f14fa70_d0079f91?usp=email : PS5, Line 451: } I'm a bit unsure about that. In the (unlikely) case of time_elapsed > max_timeout (not sure if this could happen, but maybe if the userland process happens to be busy with ill-behaved scripts?) then we'll not do any AUTH_PENDING at all? Or am I misreading this? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1293?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icc31b7fa0da86220df45552aecc15dc6c769cd54 Gerrit-Change-Number: 1293 Gerrit-PatchSet: 5 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 17 Nov 2025 07:59:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
