And with that, the #pragma in ssl.c can finally go...
Change makes sense (took me a bit to understand the intricacies of
buf_read_u16() and why it's not returning an uint16_t) - and this is arguably
more correct, as the old code did not handle the "buffer too small" case
nicely (it did, by having "len" end up being 0xffff, and buf_len() will
then be 0 or 1, which is definitely smaller then "len" - but now it's
quite explicit and easier to understand).
Smoke tested on Linux.
Your patch has been applied to the master branch.
commit abe32bce066ccf77db7e49159ea0f8111c02a3c4
Author: Frank Lichtenheld
Date: Sun Nov 16 22:54:27 2025 +0100
ssl: Clean up type handling in parse_early_negotiation_tlvs()
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1302
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg34487.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
