cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1385?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age ...................................................................... tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age Coverity complained about "overflow_before_widen" because there is a theoretical overflow that can happen even though the target value is wide enough. For useful values of max_days this is irrelevant but Coverity is not wrong, so change the code accordingly. Change-Id: Ie7308d549182a95b86cd113e4a8cc65ff45ba3d7 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1385 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34585.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/tls_crypt.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/85/1385/2 diff --git a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.c index 318c939..9026cff 100644 --- a/src/openvpn/tls_crypt.c +++ b/src/openvpn/tls_crypt.c @@ -539,7 +539,7 @@ int64_t timestamp; memcpy(×tamp, metadata + 1, sizeof(int64_t)); timestamp = (int64_t)ntohll((uint64_t)timestamp); - int64_t max_age_in_seconds = max_days * 24 * 60 * 60; + int64_t max_age_in_seconds = (int64_t)max_days * 24 * 60 * 60; if (now - timestamp > max_age_in_seconds) { msg(M_WARN, "ERROR: Client key is too old."); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1385?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie7308d549182a95b86cd113e4a8cc65ff45ba3d7 Gerrit-Change-Number: 1385 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
