Trivial enough.
Not sure we really *need* this - the documentation for RegGetValueW()
states
If the data is a string, the function checks for a terminating
null character. If one is not found, the string is stored with
a null terminator if the buffer is large enough to accommodate
the extra character. Otherwise, the function fails and returns
ERROR_MORE_DATA.
which reads to me like "either we get 'err' or it is always null
terminated", so the "if (!err)" part would catch this anyway.
I have no way to actually test this beyond "does it compile" - which
it does.
Your patch has been applied to the master branch.
commit a1c41b0acb6905506ad35e339396206653fee5cc
Author: Heiko Hund
Date: Sun Nov 23 12:58:46 2025 +0100
iservice: make sure registry string is terminated
Signed-off-by: Heiko Hund <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1392
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg34610.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
