Trivial enough. Stared-at-code, and buildbot did the compile tests.
I don't think this can ever happen in our context - search_domains
comes from a single call chain, and is initialized here
PWSTR wide_search_domains;
wide_search_domains = utf8to16(search_domains);
if (!wide_search_domains)
{
return ERROR_OUTOFMEMORY;
}
SetNrptExcludeRules(nrpt_key, ovpn_pid, wide_search_domains);
free(wide_search_domains);
.. but this change does not hurt, and "if (NULL) return FALSE" matches
the function description "is 'domain' in 'list'? FALSE = no" just fine.
Your patch has been applied to the master branch.
commit 2e2ac94e9cf3d0bdb28339594c8236fa98784967
Author: Heiko Hund
Date: Sun Nov 23 13:00:23 2025 +0100
iservice: check for NULL pointer
Signed-off-by: Heiko Hund <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1393
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg34611.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
