Stared long and hard at the code. Found lots of "this cannot work, really?"
staring at it, that are all getting fixed in additional single-line patches
later on - this is not a useful patch granularity, sending 8 patches to
fix like 6 single-line bugs. Reviewing and testing something where the
starting code is broken to no end and a single patch will not bring it
into a correct state is not a good use of my time.
This said, this single-line change (plus a bit of movearound in preparation
for the next patch) does what it says, calculate "converted_size"
correctly, in bytes ("_len" in glyphs, "_size" = in bytes).
Your patch has been applied to the master branch.
commit ac6c9d65701ed6d41691497846a47cb4e72b2878
Author: Heiko Hund
Date: Wed Nov 26 11:34:21 2025 +0100
iservice: fix calculation of converted domains size
Signed-off-by: Heiko Hund <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1390
Message-Id: <[email protected]>
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
