cron2 has uploaded a new patch set (#4) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1395?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: iservice: fix off by one error ...................................................................... iservice: fix off by one error In case there is more than one non-ignored interface domain, the start of the next domain was off by one glyph. That meant that all but the first domain was ignored when converting to MULTI_SZ. Reported-by: Marc Heuse <[email protected]> Reported-by: [email protected] Change-Id: I3ebf30f6d9edc66eb54fb3f1b5634c96d156b1ca Signed-off-by: Heiko Hund <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1395 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34678.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpnserv/interactive.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/95/1395/4 diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index ce37ac2f..13e303a 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -2234,7 +2234,8 @@ return NO_ERROR; } - pos = comma + 1; + /* Comma pos is now +1 after adding leading dot */ + pos = comma + 2; } } } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1395?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3ebf30f6d9edc66eb54fb3f1b5634c96d156b1ca Gerrit-Change-Number: 1395 Gerrit-PatchSet: 4 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
