Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1404?usp=email

to review the following change.


Change subject: Fix incorrect RST syntax in Changes.rst
......................................................................

Fix incorrect RST syntax in Changes.rst

Single-backquotes are not allowed.  Change every occurance to double.

Change-Id: I621622905abd4d5ec41468ec3bade4ad6c1d1f31
Signed-off-by: Gert Doering <[email protected]>
---
M Changes.rst
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/04/1404/1

diff --git a/Changes.rst b/Changes.rst
index 40984f5..d47c990 100644
--- a/Changes.rst
+++ b/Changes.rst
@@ -314,17 +314,17 @@
   use from "ifconfig", this change repairs functionality (this has
   been backported to 2.6.15, but is not in earlier 2.6 versions).

-- `max-routes-per-client 0` used to be silently upgraded to `1`.  This
+- ``max-routes-per-client 0`` used to be silently upgraded to ``1``.  This
   now produces an error.

-- `ifconfig` and `ifconfig-ipv6` values are now stored in pre-connect
+- ``ifconfig`` and ``ifconfig-ipv6`` values are now stored in pre-connect
   options cache, and will be restored to pre-connect values on reconnects
   if the server stops pushing the respective option.

-- `tapctl.exe` helper binary on Windows has been reworked to improve
+- ``tapctl.exe`` helper binary on Windows has been reworked to improve
   help texts (making clear that it can not only do TAP-Adapters but
   Win-DCO as well), add printing of the hwid to all adapter outputs, and
-  change the default adapter type created to `ovpn-dco`.
+  change the default adapter type created to ``ovpn-dco``.

 - the default for ``multihome`` egress interface handling has changed.
   2.7.0 will default to ipi_ifindex=0, that is, leave the decision to the
@@ -418,7 +418,7 @@


 Improved ``--mssfix`` and ``--fragment`` calculation
-    The ``--mssfix`` and ``--fragment`` options now allow an optional 
:code:`mtu`
+    The ``--mssfix`` and ``--fragment`` options now allow an optional 
:code:``mtu``
     parameter to specify that different overhead for IPv4/IPv6 should taken 
into
     account and the resulting size is specified as the total size of the VPN 
packets
     including IP and UDP headers.
@@ -547,7 +547,7 @@
 - CHACHA20-POLY1305 is included in the default of ``--data-ciphers`` when 
available.
 - Option ``--prng`` is ignored as we rely on the SSL library random number 
generator.
 - Option ``--nobind`` is default when ``--client`` or ``--pull`` is used in 
the configuration
-- :code:`link_mtu` parameter is removed from environment or replaced with 0 
when scripts are
+- :code:``link_mtu`` parameter is removed from environment or replaced with 0 
when scripts are
   called with parameters. This parameter is unreliable and no longer 
internally calculated.

 - control channel packet maximum size is no longer influenced by
@@ -809,7 +809,7 @@
     wait for the second factor authentication to complete.

     This feature currently requires usage of the managent interface
-    on both client and server side. See the `management-notes.txt`
+    on both client and server side. See the ``management-notes.txt``
     ``client-pending-auth`` and ``cr-response`` commands for more
     details.


--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1404?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I621622905abd4d5ec41468ec3bade4ad6c1d1f31
Gerrit-Change-Number: 1404
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to