Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1411?usp=email
to review the following change.
Change subject: Remove remainders of --no-name-remaping option
......................................................................
Remove remainders of --no-name-remaping option
This option was removed in 2.5 (commit c3f565f059) but still showed
up in the ``openvpn --help`` text and in a Q&A section of the man page.
Change-Id: Ib15bd4148872db39a4c8291796a5da211bb20a87
Signed-off-by: Gert Doering <[email protected]>
---
M doc/man-sections/script-options.rst
M src/openvpn/options.c
2 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/11/1411/1
diff --git a/doc/man-sections/script-options.rst
b/doc/man-sections/script-options.rst
index 670cd33..cadd464 100644
--- a/doc/man-sections/script-options.rst
+++ b/doc/man-sections/script-options.rst
@@ -571,8 +571,8 @@
a filename, etc.
*Q: Can string remapping be disabled?*
- Yes, by using the ``--no-name-remapping`` option, however this
- should be considered an advanced option.
+ No. The options ``--no-name-remapping`` and ``--compat-names`` have
+ been removed in 2.5 because they were considered too insecure.
Here is a brief rundown of OpenVPN's current string types and the
permitted character class for each string:
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 4794315..0257418f 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -474,8 +474,6 @@
" for generated tokens can be set.\n"
"--auth-user-pass-optional : Allow connections by clients that don't\n"
" specify a username/password.\n"
- "--no-name-remapping : (DEPRECATED) Allow Common Name and X509 Subject to
include\n"
- " any printable character.\n"
"--client-to-client : Internally route client-to-client traffic.\n"
"--duplicate-cn : Allow multiple clients with the same common name to\n"
" concurrently connect.\n"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1411?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib15bd4148872db39a4c8291796a5da211bb20a87
Gerrit-Change-Number: 1411
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
