cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1417?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: CMake: For VS build, switch from /W2 to /W3 ...................................................................... CMake: For VS build, switch from /W2 to /W3 But exclude the added checks that currently have failures so that we can keep /WX enabled. Basically this excludes -Wconversion and -Wsign-compare, as expected from our GCC/Clang flags. Github: #382 Change-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1417 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34876.html Signed-off-by: Gert Doering <[email protected]> --- M CMakeLists.txt 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/17/1417/4 diff --git a/CMakeLists.txt b/CMakeLists.txt index b3142e4..906fa04 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -85,9 +85,12 @@ if (USE_WERROR) add_compile_options(/WX) endif () + # C4018: signed/unsigned mismatch + # C4244: conversion from 'type1' to 'type2', possible loss of data + # C4267: conversion from 'size_t' to 'type', possible loss of data add_compile_options( /MP - /W2 + /W3 /wd4018 /wd4267 /wd4244 /sdl /Qspectre /guard:cf -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1417?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iffc114939cb37129057e9c4864fae9e09c3c7fe4 Gerrit-Change-Number: 1417 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
