Attention is currently required from: davidben, flichtenheld.

plaisthos has posted comments on this change by davidben. ( 
http://gerrit.openvpn.net/c/openvpn/+/1289?usp=email )

Change subject: ssl_openssl: Fix some CRL mixups
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
So I debugged this further and the root cause is that tls_root_ctx is 
shared/copied around between tls_options and key_schedule context. With the old 
implementation this was not a problem since the pointer never changed. But with 
the new implementation the pointer is freed and changed in one instance and the 
other instance will then still try to free the old pointer and that causes a 
free on an invalid pointer and that segfaults.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1289?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I31ac2a763209114267c35c4a9182a12d8d82f6fe
Gerrit-Change-Number: 1289
Gerrit-PatchSet: 2
Gerrit-Owner: davidben <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: davidben <[email protected]>
Gerrit-Comment-Date: Wed, 10 Dec 2025 13:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to