Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1435?usp=email )
Change subject: Allow test-crypto to work without the --secret argument ...................................................................... Patch Set 5: (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1435/comment/8c44e18c_770dbb08?usp=email : PS5, Line 2695: if (options->tls_server + options->tls_client + (options->shared_secret_file != NULL) > 1) > Since test_crypto does not imply shared_secret_file anymore should we add a > check here that we do no […] I think if we do that we should add it for all the "standalone" keys like genkey, show-ciphers, show-tls, show-digest. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1435?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I72947bd4f0213fd118327f740daeb1d86ae166de Gerrit-Change-Number: 1435 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 11:41:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
