Attention is currently required from: cron2, plaisthos.

ordex has posted comments on this change by cron2. ( 
http://gerrit.openvpn.net/c/openvpn/+/1444?usp=email )

Change subject: multi: Warn about failing read in multi_process_file_closed()
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1444/comment/e3f8c5d2_2d609a7d?usp=email :
PS1, Line 2837:         msg(M_WARN | M_ERRNO, "MULTI: multi_process_file_closed 
error");
FTR I like having a message on failure, but the code we just applied to 2.7 
doesn't have any. Should we be consistent?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1444?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I950863eeba67b8c006c794245a1a08752cd79fb0
Gerrit-Change-Number: 1444
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Tue, 16 Dec 2025 10:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to