Looked at the code change - looks reasonable, and makes the unit tests
build (with "-Werror") on GHA macOS builders with upgraded cmocka again
(and everything still builds and passes UTs on older library versions,
verified by GHA and BB).
We also got a LGTM from Chosi on IRC :-)
Git complained about trailing whitespace in CMakeLists.txt (and fixed
it). My understanding of CMake is that this should be correct.
Your patch has been applied to the master branch.
It will not "just cherrypick" back to release/2.6, as many of the affected
source lines are not there yet - but GHA tells me "we do not exercise any
of the warning-inducing functions yet", so we don't need it (yet) either.
commit 6db186e0b1d9783ea96e8a945a47fd23b45e4778
Author: Frank Lichtenheld
Date: Thu Dec 18 11:40:32 2025 +0100
tests/unit_tests: Port to cmocka 2.0.0 API
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1449
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg35144.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
