"Ooops". Change makes sense.
Basically auth success is "(buf[0] == 5 && buf[1] == 0)", so auth fail
needs to properly negate that... and this patch does.
Not tested beyond BB socks proxy t_client uses - which do not excercise
the "auth fail" case, and the "auth succeed" case still works.
Your patch has been applied to the master branch.
commit d104917e34be43890a86c532329780037e419085
Author: Frank Lichtenheld
Date: Mon Jan 12 19:02:56 2026 +0100
socks: Fix wrong success check in socks_username_password_auth
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg35219.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
