Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
to review the following change.
Change subject: GHA: Update mbedtls to v4
......................................................................
GHA: Update mbedtls to v4
Also switch from Make to CMake for building it
because the former is not supported anymore.
Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M .github/workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/1474/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index ce730f6..9eead7c 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -366,12 +366,12 @@
- name: make check
run: make -j3 check VERBOSE=1
- mbedtls3:
+ mbedtls4:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04]
- ssllib: [mbedtls3]
+ ssllib: [mbedtls4]
build: [ normal, asan ]
include:
- build: asan
@@ -398,15 +398,19 @@
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd #
v5.0.1
with:
path: mbedtls
- submodules: true
+ submodules: recursive
# versioning=semver-coerced
repository: Mbed-TLS/mbedtls
- ref: v3.6.5
- - name: "mbedtls: make no_test"
- run: make -j3 no_test SHARED=1
+ ref: v4.0.0
+ - uses: lukka/get-cmake@2ecc21724e5215b0e567bc399a2602d2ecb48541 # v4.1.1
+ - name: "mbedtls: cmake"
+ run: cmake -B build
working-directory: mbedtls
- - name: "mbedtls: make install"
- run: sudo make install DESTDIR=/usr
+ - name: "mbedtls: cmake --build"
+ run: cmake --build build
+ working-directory: mbedtls
+ - name: "mbedtls: cmake --install"
+ run: sudo cmake --install build --prefix /usr
working-directory: mbedtls
- name: Checkout OpenVPN
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd #
v5.0.1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
