Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1477?usp=email )
Change subject: Merge stream_buf_get_next and stream_buf_set_next ...................................................................... Patch Set 3: Code-Review-1 (6 comments) File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/1477/comment/c97b5e83_9e9c469d?usp=email : PS3, Line 552: * required and other false. (full packet is ready) "otherwise"? File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/1477/comment/487937f5_d30dfd28?usp=email : PS3, Line 2067: * resets the stream buffer to be setup for the next round of "set up" http://gerrit.openvpn.net/c/openvpn/+/1477/comment/5b1e950d_159c415b?usp=email : PS3, Line 2122: * Sets the parameter buf to the current buffer of sb->buf. superfluous whitespace in the middle of the sentence http://gerrit.openvpn.net/c/openvpn/+/1477/comment/7ccb4681_dd24406d?usp=email : PS3, Line 2154: * move anything in sb->buf beyond a full beyond packet to sb->residual Remove second "beyond" http://gerrit.openvpn.net/c/openvpn/+/1477/comment/b1bcaa05_4b1c487c?usp=email : PS3, Line 2160: * If a packet is outside of the allowed range is detected, the error state Remove first "is" http://gerrit.openvpn.net/c/openvpn/+/1477/comment/73e1c3bb_381e01d3?usp=email : PS3, Line 2164: * @param length_added The length that has been added to sb->buf Would be good to add a little more information here. I see this can be 0. Is that for the initial call? When do we call this with non-zero length_added? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1477?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifd3e953104a67c8bf2a225e179865e3dbd0dbfbc Gerrit-Change-Number: 1477 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 21 Jan 2026 12:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
