This is paving the way to adding a unit test for this slightly convoluted
modify-string-in-place function - and as such, highly welcome. ACK from
Heiko, green light from the BBs (which do not really test beyond "does
it compile with no warnings", but at least that)
"git show --color-moved=zebra -w" is helpful in seeing what exactly
got moved (and reindented) and what is new ("the prototype and the
explanatory comment").
Your patch has been applied to the master branch.
commit cd533c483aa516a60d12a132761ab349f9b8b399
Author: Frank Lichtenheld
Date: Mon Jan 19 22:49:22 2026 +0100
openvpnserv: Factor out the string conversion from GetItfDnsDomains
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Heiko Hund <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1458
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg35343.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
