This is most welcome... the function in question has so many edge cases
it's really hard to "just review", and being able to systematically test
is great (more tests could be necessary to cover everything :-) ).
The "mingw <-> autoconf <-> cmocka (cross-build)" interaction is not
really perfect yet - if there is no cross-built cmocka, configure will
not notice, and "make check" will just fail with
pkey_test_utils.c:32:10: fatal error: cmocka.h: No such file or directory
32 | #include <cmocka.h>
| ^~~~~~~~~~
.. more work needed. But not not fault of this patch... so, tested
with Github Actions, and that compiles all UTs fine. It does not yet
*run* them, as far as I can see... so work on the build.yaml seems
needed.
Your patch has been applied to the master branch.
commit b10ee38ccde5f155d02fcd3e8f1b1ab454826ab0
Author: Frank Lichtenheld
Date: Mon Jan 19 22:50:53 2026 +0100
openvpnserv: Add a first unit test
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1459
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg35345.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
