Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1485?usp=email )
Change subject: status: Avoid conversion warnings in status_read/status_printf ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/openvpn/status.c: http://gerrit.openvpn.net/c/openvpn/+/1485/comment/d724e493_5742107d?usp=email : PS2, Line 241: if (write(so->fd, buf, (unsigned int)len) != len) this change confuses me. In my manpage, `write()` wants a `size_t count` (linux) or `size_t nbytes` (FreeBSD), and so `size_t len` should be perfectly fine. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1485?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff1343a2f8cc7e32b8f36b359a00248e4dc3e8c9 Gerrit-Change-Number: 1485 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Sat, 24 Jan 2026 18:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
