Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1499?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: tunnel_server_*(): close correct inotify fd
......................................................................
tunnel_server_*(): close correct inotify fd
On a full SIGUSR1 restart of a p2mp server compiled with
--enable-async-push, tunnel_server_{udp,tcp}() will try to close and
reopen the "inotify" control file descriptor. For whatever reason,
the original code referenced the wrong context, always closing fd 0.
As a consequence of this, on the second SIGUSR1 restart, the server
will close() the first active socket file descriptor, and if there
are active DCO clients, the resulting event confusion will lead to
an ASSERT(!mi->halt).
Fix by closing the correct FD. Add logging.
This is a backport of commit 5521872f80313060 to the "old p2mp code"
with a separate mudp.c and mtcp.c for UDP and TCP servers, respectively.
Github: fixes OpenVPN/openvpn#966
Change-Id: Idcb1421b9f7fcbee9620fd1d45cceab050751373
Signed-off-by: Gert Doering <[email protected]>
Acked-by: Arne Schwabe <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1499
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg35493.html
Signed-off-by: Gert Doering <[email protected]>
---
M src/openvpn/mtcp.c
M src/openvpn/mudp.c
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/1499/2
diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c
index 96408d1..3e33b15 100644
--- a/src/openvpn/mtcp.c
+++ b/src/openvpn/mtcp.c
@@ -850,7 +850,9 @@
}
#ifdef ENABLE_ASYNC_PUSH
- close(top->c2.inotify_fd);
+ msg(D_LOW, "%s: close multi.top.c2.inotify_fd (%d)",
+ __func__, multi.top.c2.inotify_fd);
+ close(multi.top.c2.inotify_fd);
#endif
/* shut down management interface */
diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c
index 0492311..f7c9ffd 100644
--- a/src/openvpn/mudp.c
+++ b/src/openvpn/mudp.c
@@ -524,7 +524,9 @@
}
#ifdef ENABLE_ASYNC_PUSH
- close(top->c2.inotify_fd);
+ msg(D_LOW, "%s: close multi.top.c2.inotify_fd (%d)",
+ __func__, multi.top.c2.inotify_fd);
+ close(multi.top.c2.inotify_fd);
#endif
/* shut down management interface */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1499?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Idcb1421b9f7fcbee9620fd1d45cceab050751373
Gerrit-Change-Number: 1499
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
