Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1504?usp=email
to review the following change.
Change subject: openvpnmscia: Improve check of vsnprintf return value
......................................................................
openvpnmscia: Improve check of vsnprintf return value
Avoid sign-compare warning and do not ignore error
return values.
Change-Id: Ia57fa6d2469be08343c0457dd0213f062bc4cfa5
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpnmsica/dllmain.c
1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/04/1504/1
diff --git a/src/openvpnmsica/dllmain.c b/src/openvpnmsica/dllmain.c
index 2bb0e1b..85ebda9 100644
--- a/src/openvpnmsica/dllmain.c
+++ b/src/openvpnmsica/dllmain.c
@@ -98,11 +98,6 @@
return true;
}
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wsign-compare"
-#endif
-
void
x_msg_va(const unsigned int flags, const char *format, va_list arglist)
{
@@ -124,7 +119,7 @@
/* Field 2: The message string. */
char szBufStack[128];
int iResultLen = vsnprintf(szBufStack, _countof(szBufStack), format,
arglist);
- if (iResultLen < _countof(szBufStack))
+ if (iResultLen > 0 && (unsigned int)iResultLen < _countof(szBufStack))
{
/* Use from stack. */
MsiRecordSetStringA(hRecordProg, 2, szBufStack);
@@ -194,7 +189,3 @@
hRecordProg);
MsiCloseHandle(hRecordProg);
}
-
-#if defined(__GNUC__) || defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1504?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia57fa6d2469be08343c0457dd0213f062bc4cfa5
Gerrit-Change-Number: 1504
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
