Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1516?usp=email
to review the following change.
Change subject: port-share: log incoming connections at verb 3 only
......................................................................
port-share: log incoming connections at verb 3 only
>From "day 1" the message "Non-OpenVPN client protocol detected" was
logged at D_STREAM_ERRORS level (verb 1), while it is not anything
erroneous in this context (it's inside an "port share" only block).
Bump this to D_PS_PROXY (verb 3).
Github: closes OpenVPN/openvpn#976
Change-Id: Ie5c9a88050de959cfb02e5f804323a8081ddb667
Signed-off-by: Gert Doering <[email protected]>
---
M src/openvpn/socket.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/16/1516/1
diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c
index 58ccda9..d97b770 100644
--- a/src/openvpn/socket.c
+++ b/src/openvpn/socket.c
@@ -2149,7 +2149,7 @@
{
if (!is_openvpn_protocol(&sb->buf))
{
- msg(D_STREAM_ERRORS, "Non-OpenVPN client protocol detected");
+ msg(D_PS_PROXY, "Non-OpenVPN client protocol detected");
sb->port_share_state = PS_FOREIGN;
sb->error = true;
return false;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1516?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie5c9a88050de959cfb02e5f804323a8081ddb667
Gerrit-Change-Number: 1516
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
