Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1529?usp=email
to review the following change.
Change subject: clang-format: Add missing InsertBraces: true
......................................................................
clang-format: Add missing InsertBraces: true
This takes care to add missing braces in
case of one-line if-statements or loops.
Apparently we never tested this specific error
and we had no existing cases in the code when
we did the reformat. Noticed this during a code
review.
Change-Id: Idb1e96a4d0a618089db4290c5980d192985b5d29
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M .clang-format
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/29/1529/1
diff --git a/.clang-format b/.clang-format
index 1cce4c3..cbec0a4 100644
--- a/.clang-format
+++ b/.clang-format
@@ -31,6 +31,7 @@
IndentGotoLabels: false
IndentWidth: '4'
IndentWrappedFunctionNames: false
+InsertBraces: true
KeepEmptyLinesAtTheStartOfBlocks: false
MaxEmptyLinesToKeep: '2'
PointerAlignment: Right
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1529?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idb1e96a4d0a618089db4290c5980d192985b5d29
Gerrit-Change-Number: 1529
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
