Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1531?usp=email
to review the following change.
Change subject: management: resync timer on bytecount interval change
......................................................................
management: resync timer on bytecount interval change
coarse_timer_wakeup tracks when the next timer-driven task will occur.
If a user issues `bytecount n` via the management interface, but the
next scheduled wakeup is more than n seconds away, bandwidth logging
will be delayed until that timer fires.
To ensure timely logging, reset the timer whenever a new `bytecount`
command is received. This guarantees that logging begins exactly n
seconds after the command, matching the user-defined interval.
Change-Id: Ibea20c0f2c3df9f1f6509d662ab2b5fb4ce5e18d
Signed-off-by: Ralf Lici <[email protected]>
---
M src/openvpn/manage.c
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/31/1531/1
diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 0e4afa2..6efe2d1 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -42,6 +42,7 @@
#include "manage.h"
#include "openvpn.h"
#include "dco.h"
+#include "multi.h"
#include "memdbg.h"
@@ -485,6 +486,28 @@
man->connection.bytecount_update_seconds = 0;
event_timeout_clear(&man->connection.bytecount_update_interval);
}
+
+ /* The newly received bytecount interval may be sooner than the existing
+ * coarse timer wakeup. Reset the timer to ensure it fires at the correct,
+ * earlier time.
+ */
+ if (man->persist.callback.arg)
+ {
+ struct context *c;
+
+ if (man->settings.flags & MF_SERVER)
+ {
+ struct multi_context *m = man->persist.callback.arg;
+ c = &m->top;
+ }
+ else
+ {
+ c = man->persist.callback.arg;
+ }
+
+ reset_coarse_timers(c);
+ }
+
msg(M_CLIENT, "SUCCESS: bytecount interval changed");
}
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1531?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Ibea20c0f2c3df9f1f6509d662ab2b5fb4ce5e18d
Gerrit-Change-Number: 1531
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
