Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1537?usp=email
to review the following change.
Change subject: options: make `tun` the default for `--dev`
......................................................................
options: make `tun` the default for `--dev`
With this change, OpenVPN can be launched without specifying
any --dev option and it will start a `tun` (L3) tunnel with the
interface named `tunX`.
As before, this behaviour can be changed using --dev or --dev-type.
Existing configs won't see any behavioural change as they all
had to contain at least one --dev directive.
Change-Id: I0ca7b5b7ec1a01acaad222c99db137c94c88555a
Signed-off-by: Antonio Quartulli <[email protected]>
---
M Changes.rst
M src/openvpn/options.c
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/1537/1
diff --git a/Changes.rst b/Changes.rst
index 36af4e7..1d6c166 100644
--- a/Changes.rst
+++ b/Changes.rst
@@ -1,6 +1,14 @@
Overview of changes in 2.8
==========================
-
+User-visible Changes
+--------------------
+- Default for ``--dev`` is now ``tun``. This implies that, unless another
+ name is specified, the OpenVPN interface will always be named ``tunX``.
+ More importantly, this means that by default OpenVPN will start a L3
+ tunnel.
+ Since ``--dev`` had no default value until now, all existing
+ configurations will behave exactly the same because they all had to
+ contain one ``--dev`` directive.
Overview of changes in 2.7
==========================
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 4e1e32a..9081d1d 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -799,6 +799,7 @@
gc_init(&o->dns_options.gc);
o->mode = MODE_POINT_TO_POINT;
+ o->dev = "tun";
o->topology = TOP_UNDEF;
o->ce.proto = PROTO_UDP;
o->ce.af = AF_UNSPEC;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1537?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0ca7b5b7ec1a01acaad222c99db137c94c88555a
Gerrit-Change-Number: 1537
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
