Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1543?usp=email
to review the following change.
Change subject: auth-pam: fix discards 'const' qualifier from pointer target
type
......................................................................
auth-pam: fix discards 'const' qualifier from pointer target type
strstr now returns const char*.
Change-Id: I632368451923116e0a169ddb5b6e86a8f8486afc
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/plugins/auth-pam/utils.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/43/1543/1
diff --git a/src/plugins/auth-pam/utils.c b/src/plugins/auth-pam/utils.c
index d7b544a..a4d2d0b 100644
--- a/src/plugins/auth-pam/utils.c
+++ b/src/plugins/auth-pam/utils.c
@@ -66,12 +66,11 @@
/* state: all parameters are valid */
const char *searching = tosearch;
- char *scratch;
char temp[templen + 1];
temp[0] = 0;
- scratch = strstr(searching, searchfor);
+ const char *scratch = strstr(searching, searchfor);
if (!scratch)
{
return strdup(tosearch);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1543?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I632368451923116e0a169ddb5b6e86a8f8486afc
Gerrit-Change-Number: 1543
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
