Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1546?usp=email
to review the following change.
Change subject: ntlm: fix discards 'const' qualifier from pointer target type
......................................................................
ntlm: fix discards 'const' qualifier from pointer target type
Since glibc-2.43:
For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr,
strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers
into their input arrays now have definitions as macros that return a
pointer to a const-qualified type when the input argument is a pointer
to a const-qualified type.
fixes:
src/openvpn/ntlm.c: In function 'ntlm_phase_3':
src/openvpn/ntlm.c:241:15: warning: assignment discards 'const' qualifier
from pointer target type [-Wdiscarded-qualifiers]
241 | separator = strchr(p->up.username, '\\');
| ^
Change-Id: I2703f15144661f9cadfc8750884db270f3a5bfc6
Signed-off-by: Rudi Heitbaum <[email protected]>
---
M src/openvpn/ntlm.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1546/1
diff --git a/src/openvpn/ntlm.c b/src/openvpn/ntlm.c
index 9191a8b..6da4359 100644
--- a/src/openvpn/ntlm.c
+++ b/src/openvpn/ntlm.c
@@ -230,7 +230,7 @@
char domain[128];
char username[128];
- char *separator;
+ const char *separator;
bool ntlmv2_enabled = (p->auth_method == HTTP_AUTH_NTLM2);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1546?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I2703f15144661f9cadfc8750884db270f3a5bfc6
Gerrit-Change-Number: 1546
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
