Thanks for this undertaking :-) - I admit that I was not too happy to
have "the snprintf() wrapper come back", but on really looking into the
patch, I like it a lot. All the redundant code in the snprintf() calls
where we actually check the result gets much simpler this way - and
also integer-correct without casts all over the place.
Given that this changes lots of places (= future conflicts), brings no
actual functional difference, *and* makes the code easier to read and
understand I took the liberty to apply it to 2.7 as well. Both branches
have seen a full t_client/t_server test run "just to be sure".
Your patch has been applied to the master and release/2.7 branch.
commit 1ec71fe0c0cd3f593036197abdc9486ce3665c38 (master)
commit c0e792112a7dfeff26039a03c0799b89cb86e071 (release/2.7)
Author: Frank Lichtenheld
Date: Wed Mar 4 12:04:49 2026 +0100
buffer: Add checked_snprintf function and use it in the code
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1489
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg35872.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
