From: Frank Lichtenheld <[email protected]> Avoid sign-compare warning and do not ignore error return values.
Change-Id: I7be033bc88e9a6ba474916c8be039c126e8bc574 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Arne Schwabe <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1502 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1502 This mail reflects revision 5 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe <[email protected]> diff --git a/src/openvpn/push.c b/src/openvpn/push.c index d13b24a..a948973 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -800,11 +800,6 @@ gc_free(&gc); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-compare" -#endif - bool send_push_reply(struct context *c, struct push_list *per_client_push_list) { @@ -936,7 +931,7 @@ va_start(arglist, format); len = vsnprintf(tmp, sizeof(tmp), format, arglist); va_end(arglist); - if (len > sizeof(tmp) - 1) + if (len < 0 || len >= (int)sizeof(tmp)) { return false; } @@ -944,10 +939,6 @@ return true; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - void push_reset(struct options *o) { _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
