From: Frank Lichtenheld <[email protected]> Avoid sign-compare warning and do not ignore error return values.
Change-Id: Ia57fa6d2469be08343c0457dd0213f062bc4cfa5 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1504 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1504 This mail reflects revision 6 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <[email protected]> diff --git a/src/openvpnmsica/dllmain.c b/src/openvpnmsica/dllmain.c index 2bb0e1b..85ebda9 100644 --- a/src/openvpnmsica/dllmain.c +++ b/src/openvpnmsica/dllmain.c @@ -98,11 +98,6 @@ return true; } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wsign-compare" -#endif - void x_msg_va(const unsigned int flags, const char *format, va_list arglist) { @@ -124,7 +119,7 @@ /* Field 2: The message string. */ char szBufStack[128]; int iResultLen = vsnprintf(szBufStack, _countof(szBufStack), format, arglist); - if (iResultLen < _countof(szBufStack)) + if (iResultLen > 0 && (unsigned int)iResultLen < _countof(szBufStack)) { /* Use from stack. */ MsiRecordSetStringA(hRecordProg, 2, szBufStack); @@ -194,7 +189,3 @@ hRecordProg); MsiCloseHandle(hRecordProg); } - -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
