Attention is currently required from: flichtenheld, plaisthos.

MaxF has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/29?usp=email )

Change subject: Add siphash reference implementation
......................................................................


Patch Set 8: Code-Review+2

(2 comments)

Patchset:

PS8:
I confirmed that the content of siphash_reference.c is the same as the 
reference implementation at 
https://github.com/veorq/SipHash/blob/master/siphash.c, disregarding coding 
style changes.

What I don't quite understand is why you added a MIT license on top of the 
original Public Domain statement.


File src/openvpn/siphash_reference.c:

http://gerrit.openvpn.net/c/openvpn/+/29/comment/660adec6_f9b28633?usp=email :
PS6, Line 29:
> one space too many
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/29?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1292894fe7f537049a97bee97af4419e5e854a00
Gerrit-Change-Number: 29
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: MaxF <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 12 Mar 2026 10:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: MaxF <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to