Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email
to review the following change.
Change subject: configure: Remove --enable-strict
......................................................................
configure: Remove --enable-strict
Both -Wsign-compare (via -Wextra) and -Wuninitalized (via
-Wall) are enabled by default. So this does not do anything
anymore.
While here also remove rest of --enable-strict-options which
was mostly removed in commit
2104ea62430e4d203f2cd998e053f4192798b9f1
Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M CMakeLists.txt
M configure.ac
2 files changed, 1 insertion(+), 19 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/1590/1
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 198c98f..f9cbbfd 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -112,7 +112,7 @@
add_link_options("$<$<CONFIG:Release>:/CETCOMPAT>")
endif()
else ()
- add_compile_options(-Wall -Wuninitialized)
+ add_compile_options(-Wall)
check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation)
check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes)
check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition)
diff --git a/configure.ac b/configure.ac
index ecef2b9..5da877a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -203,13 +203,6 @@
)
AC_ARG_ENABLE(
- [strict],
- [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings
(debugging option) @<:@default=no@:>@])],
- ,
- [enable_strict="no"]
-)
-
-AC_ARG_ENABLE(
[pedantic],
[AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler
warnings, will not generate a working executable (debugging option)
@<:@default=no@:>@])],
,
@@ -224,13 +217,6 @@
)
AC_ARG_ENABLE(
- [strict-options],
- [AS_HELP_STRING([--enable-strict-options], [enable strict options check
between peers (debugging option) @<:@default=no@:>@])],
- ,
- [enable_strict_options="no"]
-)
-
-AC_ARG_ENABLE(
[selinux],
[AS_HELP_STRING([--enable-selinux], [enable SELinux support
@<:@default=no@:>@])],
,
@@ -1270,13 +1256,9 @@
fi
if test "${enable_pedantic}" = "yes"; then
- enable_strict="yes"
CFLAGS="${CFLAGS} -pedantic"
AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode])
fi
-if test "${enable_strict}" = "yes"; then
- CFLAGS="${CFLAGS} -Wsign-compare -Wuninitialized"
-fi
if test "${enable_werror}" = "yes"; then
CFLAGS="${CFLAGS} -Werror"
fi
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725
Gerrit-Change-Number: 1590
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
