On Thu, Mar 26, 2026 at 02:20:16PM +0800, haixiao.yan.cn--- via Openvpn-devel wrote: > From: Haixiao Yan <[email protected]> > > The auth-pam unit test Makefile.am unconditionally assigns the TESTS variable, > causing test execution to fail during cross-compilation because the target > binaries are not executable on the build host. > > Signed-off-by: Haixiao Yan <[email protected]> > --- > tests/unit_tests/plugins/auth-pam/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/unit_tests/plugins/auth-pam/Makefile.am > b/tests/unit_tests/plugins/auth-pam/Makefile.am > index ba32013ac920..7da299ccde92 100644 > --- a/tests/unit_tests/plugins/auth-pam/Makefile.am > +++ b/tests/unit_tests/plugins/auth-pam/Makefile.am > @@ -4,8 +4,10 @@ AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING) > auth_pam Plugin Unit-Tests > > if ENABLE_PLUGIN_AUTH_PAM > check_PROGRAMS = auth_pam_testdriver > +if !CROSS_COMPILING > TESTS = $(check_PROGRAMS) > endif > +endif
Makes sense and is consistent with existing Makefile.am files in example_test and openvpn. Acked-By: Frank Lichtenheld <[email protected]> Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
