Attention is currently required from: plaisthos, selvanair. Bluca has posted comments on this change by Bluca. ( http://gerrit.openvpn.net/c/openvpn/+/1593?usp=email )
Change subject: management: add base64 multi-line input for passwords ...................................................................... Patch Set 2: (6 comments) Patchset: PS2: Applied as suggested and re-tested, thank you File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/1593/comment/b759445b_0d2c0f53?usp=email : PS1, Line 329: commands. > Update MANAGEMENT_VERSION to 6 and document that multi-line password support > requires daemon version […] Acknowledged File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/1593/comment/637bc2bb_b3e0712d?usp=email : PS1, Line 1029: * @param type The type of password being entered (e.g. "Auth", "TLS-Auth", etc) > Nitpick: "TLS-Auth" is not a valid type -- "Private Key" ? Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1593/comment/7a862134_202d00db?usp=email : PS1, Line 1102: msg(M_CLIENT, "ERROR: could not base64-decode password"); > This could lead to an unhelpful decode error or silent truncation which is > hard to debug. […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1593/comment/ba43603c_1204f5ea?usp=email : PS1, Line 1110: secure_memzero(decoded, sizeof(decoded)); > Also needs a buf_clear() somewhere as buf contains sensitive data. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1593/comment/ef07d82c_af4a08f9?usp=email : PS1, Line 1664: else if (streq(p[0], "password-base64")) > As Gert suggested, we could use "password 'Type'" with no argument and > interpret it differently base […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1593?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib99f171fb69d51f2260b44edf8ebe21ac958f233 Gerrit-Change-Number: 1593 Gerrit-PatchSet: 2 Gerrit-Owner: Bluca <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: selvanair <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: selvanair <[email protected]> Gerrit-Comment-Date: Sat, 28 Mar 2026 16:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: selvanair <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
