cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1594?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: ssl_ncp: Fix type of "found" parameter of check_pull_client_ncp ...................................................................... ssl_ncp: Fix type of "found" parameter of check_pull_client_ncp In commit 91fd9614f980b02772e4dfbb09144c822ec97df0 type of "found" was changed to uint64_t. But due to -Wconversion not yet enabled in all of init.c one occurence of the old type was missed. Change-Id: I1a6dfc175075636bc7a5761215547077a9dc397a Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Arne Schwabe <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1594 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg36364.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/ssl_ncp.c M src/openvpn/ssl_ncp.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/94/1594/2 diff --git a/src/openvpn/ssl_ncp.c b/src/openvpn/ssl_ncp.c index fdac6925..649665a 100644 --- a/src/openvpn/ssl_ncp.c +++ b/src/openvpn/ssl_ncp.c @@ -307,7 +307,7 @@ } bool -check_pull_client_ncp(struct context *c, const unsigned int found) +check_pull_client_ncp(struct context *c, const uint64_t found) { if (found & OPT_P_NCP) { diff --git a/src/openvpn/ssl_ncp.h b/src/openvpn/ssl_ncp.h index 837f662..dc3a750 100644 --- a/src/openvpn/ssl_ncp.h +++ b/src/openvpn/ssl_ncp.h @@ -49,7 +49,7 @@ * * @return Wether the client NCP process suceeded or failed */ -bool check_pull_client_ncp(struct context *c, unsigned int found); +bool check_pull_client_ncp(struct context *c, uint64_t found); /** * Iterates through the ciphers in server_list and return the first -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1594?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1a6dfc175075636bc7a5761215547077a9dc397a Gerrit-Change-Number: 1594 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
