Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1595?usp=email )
Change subject: OpenSSL 4.0: Use X509_check_certificate_times instead of X509_cmp_time ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1595/comment/ce3d6801_f2791ace?usp=email : PS2, Line 691: msg(D_TLS_DEBUG_MED, "Failed to initialise certificate verification parameters."); Shouldn't we return from the function here? http://gerrit.openvpn.net/c/openvpn/+/1595/comment/ed877e20_2571c8e7?usp=email : PS2, Line 708: if (ret == X509_V_ERR_ERROR_IN_CERT_NOT_AFTER_FIELD) error, not ret -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1595?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25ded81f0f5ddd5 Gerrit-Change-Number: 1595 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 01 Apr 2026 10:34:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
