Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1662?usp=email
to review the following change.
Change subject: sample: Fix cppcheck error invalidPrintfArgType_sint
......................................................................
sample: Fix cppcheck error invalidPrintfArgType_sint
Change-Id: Ia7ad24181bd97dccbb77865c10e829778f72a506
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M sample/sample-plugins/log/log_v3.c
M sample/sample-plugins/simple/base64.c
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/62/1662/1
diff --git a/sample/sample-plugins/log/log_v3.c
b/sample/sample-plugins/log/log_v3.c
index fae7bc4..09c6735 100644
--- a/sample/sample-plugins/log/log_v3.c
+++ b/sample/sample-plugins/log/log_v3.c
@@ -91,7 +91,7 @@
}
/* Print some version information about the OpenVPN process using this
plug-in */
- printf("log_v3: OpenVPN %s (Major: %i, Minor: %i, Patch: %s)\n",
args->ovpn_version,
+ printf("log_v3: OpenVPN %s (Major: %u, Minor: %u, Patch: %s)\n",
args->ovpn_version,
args->ovpn_version_major, args->ovpn_version_minor,
args->ovpn_version_patch);
/* Which callbacks to intercept. */
diff --git a/sample/sample-plugins/simple/base64.c
b/sample/sample-plugins/simple/base64.c
index ab6aed8..3b11543 100644
--- a/sample/sample-plugins/simple/base64.c
+++ b/sample/sample-plugins/simple/base64.c
@@ -122,7 +122,7 @@
ovpn_base64_decode = args->callbacks->plugin_base64_decode;
/* Print some version information about the OpenVPN process using this
plug-in */
- ovpn_log(PLOG_NOTE, PLUGIN_NAME, "OpenVPN %s (Major: %i, Minor: %i,
Patch: %s)\n",
+ ovpn_log(PLOG_NOTE, PLUGIN_NAME, "OpenVPN %s (Major: %u, Minor: %u,
Patch: %s)\n",
args->ovpn_version, args->ovpn_version_major,
args->ovpn_version_minor,
args->ovpn_version_patch);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1662?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia7ad24181bd97dccbb77865c10e829778f72a506
Gerrit-Change-Number: 1662
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
