Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1673?usp=email
to review the following change.
Change subject: Do not use deprecated aliases on Windows
......................................................................
Do not use deprecated aliases on Windows
Both these work perfectly fine but are discouraged
and might cause warnings by compilers.
Identified by cppcheck.
Change-Id: I04e35928244e6ecda8c58285a812516662b50742
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/cryptoapi.c
M src/openvpnmsica/openvpnmsica.c
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/73/1673/1
diff --git a/src/openvpn/cryptoapi.c b/src/openvpn/cryptoapi.c
index e17936a..bf80bbd 100644
--- a/src/openvpn/cryptoapi.c
+++ b/src/openvpn/cryptoapi.c
@@ -235,7 +235,7 @@
if (pvext && cbext >= sizeof(CERT_TEMPLATE_EXT))
{
const CERT_TEMPLATE_EXT *cte = (const CERT_TEMPLATE_EXT *)pvext;
- if (!stricmp(cert_prop, cte->pszObjId))
+ if (!_stricmp(cert_prop, cte->pszObjId))
{
/* found direct OID match with certificate property specified
*/
gc_free(&gc);
@@ -244,7 +244,7 @@
const CRYPT_OID_INFO *tmpl_oid =
find_oid(CRYPT_OID_INFO_NAME_KEY, tmpl_name,
CRYPT_TEMPLATE_OID_GROUP_ID);
- if (tmpl_oid && !stricmp(tmpl_oid->pszOID, cte->pszObjId))
+ if (tmpl_oid && !_stricmp(tmpl_oid->pszOID, cte->pszObjId))
{
/* found OID match in extension against resolved key */
gc_free(&gc);
diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c
index d698c04..95e457c 100644
--- a/src/openvpnmsica/openvpnmsica.c
+++ b/src/openvpnmsica/openvpnmsica.c
@@ -508,7 +508,7 @@
*iTicks += MSICA_ADAPTER_TICK_SIZE;
break;
}
- else if (wcsicmp(szDisplayName, pAdapterOther->szName) == 0)
+ else if (_wcsicmp(szDisplayName, pAdapterOther->szName) == 0)
{
/* Adapter with a same name found. */
for (LPCWSTR hwid = pAdapterOther->szzHardwareIDs;; hwid +=
wcslen(hwid) + 1)
@@ -521,7 +521,7 @@
dwResult = ERROR_ALREADY_EXISTS;
goto cleanup_pAdapterList;
}
- else if (wcsicmp(hwid, szHardwareId) == 0)
+ else if (_wcsicmp(hwid, szHardwareId) == 0)
{
/* This is an adapter with the requested hardware ID. We
already have what we
* want! */
@@ -583,7 +583,7 @@
for (struct tap_adapter_node *pAdapter = pAdapterList; pAdapter != NULL;
pAdapter = pAdapter->pNext)
{
- if (wcsicmp(szDisplayName, pAdapter->szName) == 0)
+ if (_wcsicmp(szDisplayName, pAdapter->szName) == 0)
{
/* Adapter found. */
WCHAR szArgument[8 /*disable=|enable=|delete=*/
@@ -1083,7 +1083,7 @@
for (struct tap_adapter_node *pAdapter = pAdapterList;
pAdapter != NULL;
pAdapter = pAdapter->pNext)
{
- if (wcsicmp(szName, pAdapter->szName) == 0)
+ if (_wcsicmp(szName, pAdapter->szName) == 0)
{
/* Adapter found. */
dwResult = tap_delete_adapter(NULL, &pAdapter->guid,
&bRebootRequired);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1673?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04e35928244e6ecda8c58285a812516662b50742
Gerrit-Change-Number: 1673
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
