Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1671?usp=email
to review the following change.
Change subject: openvpnserv: Use same variant of UuidToString and RpcStringFree
......................................................................
openvpnserv: Use same variant of UuidToString and RpcStringFree
Probably not a real issue since it should always use the
W version in our case, but still unclean.
Fixes a cppcheck complaint.
Change-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1671/1
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index e25c511..bd310e4 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3484,7 +3484,7 @@
swprintf(ovpn_pipe_name, _countof(ovpn_pipe_name),
L"\\\\.\\pipe\\" _L(PACKAGE) L"%ls\\service_%lu_%ls",
service_instance,
GetCurrentThreadId(), pipe_uuid_str);
- RpcStringFree(&pipe_uuid_str);
+ RpcStringFreeW(&pipe_uuid_str);
/* make a security descriptor for the named pipe with access
* restricted to the user and SYSTEM
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1671?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1
Gerrit-Change-Number: 1671
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
