Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1677?usp=email
to review the following change.
Change subject: tun: Remove one useless if check
......................................................................
tun: Remove one useless if check
The condition was already checked in an outer if check.
Identified by cppcheck.
Change-Id: I0aeb4583707a80592ec2577fbb060f7fbcb73e48
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/tun.c
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/1677/1
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index f46802f..e7193d8 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -5772,13 +5772,10 @@
continue;
}
- if (tt->backend_driver == DRIVER_DCO)
+ const char *last_sep = strrchr(dev_if->device_interface, '\\');
+ if (!last_sep || strcmp(last_sep + 1, DCO_WIN_REFERENCE_STRING) !=
0)
{
- char *last_sep = strrchr(dev_if->device_interface, '\\');
- if (!last_sep || strcmp(last_sep + 1,
DCO_WIN_REFERENCE_STRING) != 0)
- {
- continue;
- }
+ continue;
}
path = dev_if->device_interface;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1677?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0aeb4583707a80592ec2577fbb060f7fbcb73e48
Gerrit-Change-Number: 1677
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
