From: Frank Lichtenheld <[email protected]> If mi is NULL, the previous code lines already segfaulted.
Identified by cppcheck. Change-Id: If58bb807842b7b95aeffe6849e7a7344e4925762 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1667 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1667 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <[email protected]> diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 06e3758..a957fdf 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3054,8 +3054,8 @@ #ifdef MULTI_DEBUG_EVENT_LOOP printf("POST %s[%d] to=%d lo=%d/%d w=%" PRIi64 "/%ld\n", id(mi), (int)(mi == m->pending), - mi ? mi->context.c2.to_tun.len : -1, mi ? mi->context.c2.to_link.len : -1, - (mi && mi->context.c2.fragment) ? mi->context.c2.fragment->outgoing.len : -1, + mi->context.c2.to_tun.len, mi->context.c2.to_link.len, + mi->context.c2.fragment ? mi->context.c2.fragment->outgoing.len : -1, (int64_t)mi->context.c2.timeval.tv_sec, (long)mi->context.c2.timeval.tv_usec); #endif } _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
