Thanks for looking into this, thanks Heiko for review and +2.
I did some stare-at-code (looks good). BB did lots of test compiles
and test runs - some red, due to spurious "test 1* failures", which
are unrelated to this (unix platforms fail, windows-only code changes).
Understanding the second one took me a bit of time - basically, if
there are no addresses whatsoever, addr_list[] will be uninitialized
(because no strcpy()) and then pased on to SetNrptRule(). Not sure if
this can happen in practice, not now it's clear "it can't".
Your patch has been applied to the master and release/2.7 branch (bugfix).
commit 50bcb9206b1dc3100a6b20cf569c4caf9c9105e3 (master)
commit d3eb09b559ef7832a236934363e3c0aa5d855307 (release/2.7)
Author: Frank Lichtenheld
Date: Wed May 13 17:08:57 2026 +0200
openvpnserv: Address some uninitVariable warnings from cppcheck
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Heiko Hund <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1674
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg36908.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
