cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1671?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by d12fk Change subject: openvpnserv: always use W variant of RpcStringFree() ...................................................................... openvpnserv: always use W variant of RpcStringFree() Probably not a real issue since it should always use the W version in our case, but still unclean. Fixes a cppcheck complaint. Change-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Heiko Hund <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1671 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg36915.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpnserv/interactive.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1671/3 diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 7726bc9..788a578 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -3487,7 +3487,7 @@ swprintf(ovpn_pipe_name, _countof(ovpn_pipe_name), L"\\\\.\\pipe\\" _L(PACKAGE) L"%ls\\service_%lu_%ls", service_instance, GetCurrentThreadId(), pipe_uuid_str); - RpcStringFree(&pipe_uuid_str); + RpcStringFreeW(&pipe_uuid_str); /* make a security descriptor for the named pipe with access * restricted to the user and SYSTEM -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1671?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1 Gerrit-Change-Number: 1671 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: d12fk <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
