Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1679?usp=email )
Change subject: Replace strtok with strtok_r ...................................................................... Patch Set 4: (1 comment) File src/openvpn/options_util.c: http://gerrit.openvpn.net/c/openvpn/+/1679/comment/0fcc165a_f8562a96?usp=email : PS4, Line 51: char *lasts; The Linux man page for strtok_r warns "On some implementations, *saveptr is required to be NULL on the first call to strtok_r() that is being used to parse str." So maybe we should initialize it to NULL instead of giving it uninitialized? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1679?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I70560efd113308b7377424127eb2c1da4266371a Gerrit-Change-Number: 1679 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <[email protected]> Gerrit-CC: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 15:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
