Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1683?usp=email )
Change subject: dco: remove iroute at client exit time instead of delayed exit ...................................................................... Patch Set 4: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1683/comment/05fca6cd_7ed20462?usp=email : PS4, Line 28: I think it would be helpful to add a short comment on why this is a DCO-specific problem. It is probably obvious to you since you know how differently the iroutes are implemented in the non-DCO case. But I think it would make the patch easier to understand for people less familiar with the code. File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/1683/comment/04747dd8_aea88847?usp=email : PS4, Line 537: /* DCO iroutes must be removed now, because the delay introduced by this You might even consider adding that explanation on why it is DCO-only here in the comment? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1683?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0ba723d12d433e6e020588b7b0c3ba10bcf8c44f Gerrit-Change-Number: 1683 Gerrit-PatchSet: 4 Gerrit-Owner: ordex <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Thu, 21 May 2026 11:23:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
