Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1703?usp=email )
Change subject: Add support for user defined L3 master devices ...................................................................... Patch Set 1: Code-Review-1 (4 comments) File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1703/comment/ed5c2fad_21f38c6c?usp=email : PS1, Line 308: Specify the L3 master device (such as VRF) to which the tunnel trailing whitespace File src/openvpn/networking_sitnl.c: http://gerrit.openvpn.net/c/openvpn/+/1703/comment/ff1dde5f_2179873d?usp=email : PS1, Line 1063: int ifindex, l3mdev_index, ret = -1; there is no reason to initialize values to -1 if you do overwrite this immediately. This makes cppcheck unhappy. http://gerrit.openvpn.net/c/openvpn/+/1703/comment/2ebe5771_fa394ec7?usp=email : PS1, Line 1067: ifindex = if_nametoindex(iface); just initialize the variable here. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1703/comment/70f6ad5e_5e72ec63?usp=email : PS1, Line 6499: else if (streq(p[0], "l3mdev") && p[1] && !p[2]) Addition to usage string seems to be missing -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1703?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I115a17a2c61c65f48aea41d94150f34ea31f82da Gerrit-Change-Number: 1703 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2026 13:38:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
