Attention is currently required from: cron2, plaisthos.

ordex has posted comments on this change by cron2. ( 
http://gerrit.openvpn.net/c/openvpn/+/1712?usp=email )

Change subject: dns: Fix memory leak in dns_server_addr_parse
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
I wonder why we don't move the check directly at the beginning of the function.
What's the purpose of performing that kind of check after having done a lot of 
things that have no meaning if the check if false?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1712?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7ec318c86af994284d1c6272e3bbe2b1ede160fd
Gerrit-Change-Number: 1712
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]>
Gerrit-Reviewer: d12fk <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Wed, 17 Jun 2026 20:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to