Attention is currently required from: plaisthos. ordex has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1729?usp=email )
Change subject: multi: don't let stale-routes-check delete permanent routes ...................................................................... Patch Set 1: (1 comment) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1729/comment/a9a46ab7_6fd7dcb5?usp=email : PS1, Line 1363: if (multi_route_defined(m, r) && !(r->flags & MULTI_ROUTE_PERMANENT) > Why do we need the PERMANENT flag? Cannot we just use here r->flags & > MULTI_ROUTE_CACHE? Or are ther […] as per the commit message: "Routes learned from configuration (iroutes and pushed ifconfig addresses) and genuinely dynamic routes (TAP source addresses learned from the data channel) were both added with flags == 0, so check_stale_routes() could not tell them apart and aged out all of them." hence the PERMANENT flag is to make the distinction clear. Those learnt through TAP still have no flags and are expected to go through the stale check -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1729?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3f9834cc13c49b9249653d7d8637383f50c2fb87 Gerrit-Change-Number: 1729 Gerrit-PatchSet: 1 Gerrit-Owner: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 10:50:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
