Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1723?usp=email )

Change subject: Extract multi_check_dest_addr_allowed from multi_process_float
......................................................................


Patch Set 2: Code-Review-2

(2 comments)

File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1723/comment/7140175d_e2b8c40f?usp=email :
PS2, Line 3108: multi_check_dest_addr_allowed(struct multi_context *m, struct 
multi_instance *mi, struct mroute_addr *real)
please add documentation for new functions


http://gerrit.openvpn.net/c/openvpn/+/1723/comment/32ab1e90_2949bcce?usp=email :
PS2, Line 3160:     return true;
this return is wrong and leads to memory leak



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1723?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3d52c6d008502293c3ec57ad22d1c613dcd1a94e
Gerrit-Change-Number: 1723
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to